weiqingy commented on issue #541:
URL: https://github.com/apache/flink-agents/issues/541#issuecomment-3957083092
Hi @xintongsong, thanks for the thoughtful review! Great points across the
board. Let me address each:
- Design doc / discussion: Absolutely, I'll open a discussion thread with
the design doc so we can align before moving to implementation.
- Broader truncation semantics for STANDARD: Agreed. Defining STANDARD as
"details might be omitted to keep the logs concise" is a better semantic - it
gives us room to evolve the truncation strategy (e.g., truncating long lists,
capping nested depth) without breaking the contract. I'll update the design to
use this framing.
- Per-event overall length limit vs per-field: Makes sense. Exposing
per-string-field length ties the config too tightly to the truncation
implementation. I'll replace eventLogMaxFieldLength with a per-event overall
length limit (e.g., event-log.max-length). The internal strategy for how we
truncate to fit that limit can evolve independently.
- Config key pattern for per-class levels: This is a great call. The single
comma-separated eventLogLevels option has exactly the override composability
problem you described. I'll switch to a config key pattern like:
```
event-log.level.ChatRequestEvent: VERBOSE
event-log.level.ContextRetrievalRequestEvent: OFF
```
This way each event type has its own independently overridable config
key, and the global default can remain as event-log.level.default: STANDARD.
I'll update the design doc with these changes and open a discussion thread.
Thanks again for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
