1996fanrui commented on code in PR #27688:
URL: https://github.com/apache/flink/pull/27688#discussion_r2879346636
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointRescaleITCase.java:
##########
@@ -549,7 +561,8 @@ public static Object[][] getScaleFactors() {
// captured in-flight records, see FLINK-31963.
Object[][] parameters =
new Object[][] {
- new Object[] {"downscale", Topology.CUSTOM_PARTITIONER, 3,
2, 0L},
+ // Disable CUSTOM_PARTITIONER since it does not work well,
see FLINK-39162
+ // new Object[] {"downscale", Topology.CUSTOM_PARTITIONER,
3, 2, 0L},
Review Comment:
As I understand, if some partitioners do not support UC, it could fallback
to AC, just like the forward partitioner[1], so checkpoint is slow for these
partitioners.
Currently, the data is corrupted for custom partitioner:
- slow checkpoint is expected for disabled partitioner
- Data corrupt is not expected
That is why I think it should be treat as a bug. WDYT?
[1]
https://github.com/apache/flink/blob/4fb13082da9e15eaa20392db0f1ad21e83349cfa/flink-runtime/src/main/java/org/apache/flink/streaming/runtime/partitioner/StreamPartitioner.java#L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
