yuxiqian commented on code in PR #4294: URL: https://github.com/apache/flink-cdc/pull/4294#discussion_r2887030287
########## flink-cdc-dist-2.x/src/main/flink-cdc-bin/bin/flink-cdc.sh: ########## @@ -0,0 +1,84 @@ +#!/usr/bin/env bash +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +# Setup FLINK_HOME +args=("$@") +# Check if FLINK_HOME is set in command-line arguments by "--flink-home" +for ((i=0; i < ${#args[@]}; i++)); do Review Comment: Do we really need two `flink-cdc-dist` module as it's just a shell script? Can we just ship both (1.x and 2.x) jars into `dist` and use a command line tool to decide which version to choose, or use `./bin/flink --version` to detect it automatically? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
