noorall commented on PR #27697: URL: https://github.com/apache/flink/pull/27697#issuecomment-4001581638
> Looks ok to me. > > Just a small nit, but I'm not sure how relevant - originally I put `TestClass` in `org.apache.notflink` namespace to demonstrate that special treatment of `org.apache.flink` package was one of the reasons that class loading didn't work correctly. > > Personally I believe that due to this special treatment of `org.apache.flink` at least some user classes in tests should reside in namespaces that don't get this special treatment, and this should be fine so long as these don't leak into any published artifacts. Your concern only applies to the MiniCluster environment used in IT tests; it doesn’t affect E2E tests. In a MiniCluster, all classes brought in by the job are added to the current thread’s class loader, so deserialization always succeeds. In E2E tests, however, classes from the user JAR exist only in the user class loader, not in the current thread’s class loader. Therefore, placing `TestClass` in the `org.apache.flink` namespace is able to cover the test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
