mukul-8 commented on code in PR #27743:
URL: https://github.com/apache/flink/pull/27743#discussion_r2896458037
##########
flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java:
##########
@@ -109,7 +109,7 @@ public void addAllToProperties(Properties props) {
String keyWithoutPrefix =
entry.getKey().substring(prefix.length(),
entry.getKey().length());
- props.put(keyWithoutPrefix, entry.getValue());
+ props.put(keyWithoutPrefix, entry.getValue().toString());
Review Comment:
I've identified an issue with the current implementation. The `.toString()`
conversion affects complex types like HashMap, which produces non-deterministic
string representations due to unordered iteration. This causes the
`PythonDependencyUtilsTest.testPythonFiles` test to fail in CI (though it
passed locally due to the non-deterministic nature).
Updated the fix. Instead of converting values in DelegatingConfiguration, I
fixed the root cause in MetricConfig.getString() to use get() instead of
getProperty(), matching the pattern of other getter methods. This preserves
compatibility with Python tests while fixing the metrics reporter issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
