lincoln-lil commented on code in PR #27699:
URL: https://github.com/apache/flink/pull/27699#discussion_r2918219372
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java:
##########
@@ -573,11 +573,10 @@ private static boolean isCalcSupported(Calc calc) {
}
private static boolean areAllRexNodeDeterministic(List<RexNode> rexNodes) {
- // Delta joins may produce duplicate data, and when this data is sent
downstream, we want it
- // to be processed in an idempotent manner. However, the presence of
non-deterministic
- // functions can lead to unpredictable results, such as random
filtering or the addition of
- // non-deterministic columns. Therefore, we strictly prohibit the use
of non-deterministic
- // functions in this context to ensure consistent and reliable
processing.
+ // The presence of non-deterministic in projection or filter before
join will output
Review Comment:
nit: -> "non-deterministic functions" or "non-determinism" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
