davidradl commented on code in PR #27761:
URL: https://github.com/apache/flink/pull/27761#discussion_r2923784086
##########
flink-python/pyflink/table/tests/test_schema_operation.py:
##########
@@ -42,7 +42,23 @@ def test_get_resolved_schema(self):
['a', 'b', 'c'],
[DataTypes.BIGINT(), DataTypes.STRING(), DataTypes.STRING()],
)
- assert resolved_schema == expected_schema
+ self.assertEqual(resolved_schema, expected_schema)
+
+ def test_resolved_schema_get_columns(self):
+ physical_schema = ResolvedSchema.physical(
Review Comment:
I realise this is a port - but it worth be worth testing the computed and
metadata cases as well I think. Unelss they are already covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
