dylanhz commented on PR #27720: URL: https://github.com/apache/flink/pull/27720#issuecomment-4047339652
> good that we now don't have changes in `Parser.jj` however there are still changes in Calcite classes and if I see there are no corresponding changes in Calcite and even more there is no any PR to add them to Calcite which is not good in my opinion... @snuyanzin Thanks for the feedback! Just to confirm -- would you prefer that we avoid modifying any Calcite classes (`SqlTypeName`/`SqlTypeFamily`) entirely, and instead follow the same pattern as `RAW` (i.e. a custom `SqlBitmapTypeNameSpec` + `ExtendedRelTypeFactory`)? If so, I can update the PR right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
