raminqaf commented on code in PR #27757:
URL: https://github.com/apache/flink/pull/27757#discussion_r2941960116
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -891,21 +896,21 @@ private Stream<TestSetSpec> toTimestampLtzTestCases() {
LocalDateTime.of(1970, 1, 1, 0, 0, 0,
123000000)
.atZone(ZoneOffset.UTC)
.toInstant(),
- TIMESTAMP_LTZ(3).nullable())
+ TIMESTAMP_LTZ(5).nullable())
.testResult(
toTimestampLtz("20000202 59:59.1234567",
"yyyyMMdd mm:ss.SSSSSSS"),
"TO_TIMESTAMP_LTZ('20000202 59:59.1234567',
'yyyyMMdd mm:ss.SSSSSSS')",
LocalDateTime.of(2000, 2, 2, 0, 59, 59,
123000000)
.atZone(ZoneOffset.UTC)
.toInstant(),
- TIMESTAMP_LTZ(3).nullable())
+ TIMESTAMP_LTZ(7).nullable())
Review Comment:
@twalthr This can also introduce a breaking change. The requested format is
`yyyyMMdd mm:ss.SSSSSSS` which has a precision of 7. This should be reflected
to the output type, otherwise we will lose the precisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
