davidradl commented on code in PR #35:
URL:
https://github.com/apache/flink-connector-http/pull/35#discussion_r2946025287
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/JavaNetHttpPollingClient.java:
##########
@@ -161,6 +164,9 @@ private HttpRowDataWrapper queryAndProcess(RowData
lookupData) throws Exception
} catch (HttpStatusCodeValidationFailedException e) {
// log if we fail for status code reasons.
httpLogger.logResponse((HttpResponse<String>) e.getResponse());
+ // Enhanced error logging
+ httpErrorLogger.logLookupError(
Review Comment:
why log this as an error here - when the config might have decided to
continue on error. We already log the response but not as an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
