qinghui-xu commented on code in PR #27744:
URL: https://github.com/apache/flink/pull/27744#discussion_r2958864089
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterOptions.java:
##########
@@ -45,12 +45,15 @@ public class PrometheusPushGatewayReporterOptions {
.defaultValue("")
.withDescription("The job name under which metrics will be
pushed");
+ @Deprecated
public static final ConfigOption<Boolean> RANDOM_JOB_NAME_SUFFIX =
ConfigOptions.key("randomJobNameSuffix")
.booleanType()
- .defaultValue(true)
+ .defaultValue(false)
.withDescription(
- "Specifies whether a random suffix should be
appended to the job name.");
+ "Specifies whether random suffixing `job` label
(the old way) to avoid metric collision among reporters from taskamangers."
Review Comment:
I updated the description and regenerated the doc. And it turns out
deprecating this option will discard the entry entirely from the doc site. So
I'd postpone the deprecation for a future commit (or maybe we should still keep
doc for deprecated items that are not yet marked `forRemoval`, but that's a
separate topic) cc @rionmonster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
