lincoln-lil commented on code in PR #27732: URL: https://github.com/apache/flink/pull/27732#discussion_r2964812292
########## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BitmapSerializer.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.typeutils.base; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeutils.SimpleTypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.types.bitmap.Bitmap; + +import java.io.IOException; + +/** Serializer for {@link Bitmap}. */ +@Internal +public class BitmapSerializer extends TypeSerializerSingleton<Bitmap> { + + public static final BitmapSerializer INSTANCE = new BitmapSerializer(); + + @Override + public boolean isImmutableType() { + return false; + } + + @Override + public Bitmap createInstance() { + return Bitmap.empty(); + } + + @Override + public Bitmap copy(Bitmap from) { + return Bitmap.from(from); + } + + @Override + public Bitmap copy(Bitmap from, Bitmap reuse) { + return copy(from); + } + + @Override + public int getLength() { + return -1; + } + + @Override + public void serialize(Bitmap record, DataOutputView target) throws IOException { + byte[] bytes = record.toBytes(); + target.writeInt(bytes.length); + target.write(bytes); + } + + @Override + public Bitmap deserialize(DataInputView source) throws IOException { + int length = source.readInt(); + byte[] bytes = new byte[length]; + source.read(bytes); Review Comment: We should call `readFully` here to ensure reading complete bytes. ########## flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BitmapTypeInfo.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.typeinfo; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.serialization.SerializerConfig; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.base.BitmapSerializer; +import org.apache.flink.types.bitmap.Bitmap; + +/** Type information for {@link Bitmap}. */ +@PublicEvolving +public class BitmapTypeInfo extends TypeInformation<Bitmap> { + + private static final long serialVersionUID = 1L; + + public static final BitmapTypeInfo INSTANCE = new BitmapTypeInfo(); + + private BitmapTypeInfo() {} + + @Override + public boolean isBasicType() { + return false; + } + + @Override + public boolean isTupleType() { + return false; + } + + @Override + public int getArity() { + return 1; + } + + @Override + public int getTotalFields() { + return 1; + } + + @Override + public Class<Bitmap> getTypeClass() { + return Bitmap.class; + } + + @Override + public boolean isKeyType() { + return true; Review Comment: Considering that `Bitmap` offers in-place-update operation, it may be unsafe for datastream users to use it for `keyby`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
