weiqingy commented on PR #548:
URL: https://github.com/apache/flink-agents/pull/548#issuecomment-4160161760
@xintongsong Addressed your review feedback:
1. Moved ResourceCache and PythonMCPResourceDiscovery from plan to runtime —
these are execution concerns ("how to execute"), not plan representation ("what
the agent looks like").
2. Refactored plan tests to not use ResourceCache:
- Extracted testGetResourceNotFound and
testGetResourceFromResourceProvider from AgentPlanTest into a new
ResourceCacheTest in runtime/src/test/.
- 5 plan test files (AgentPlanDeclareToolFieldTest,
AgentPlanDeclareToolMethodTest, AgentPlanDeclareChatModelTest,
AgentPlanDeclareMCPServerTest, FunctionToolPlanTest) now call
provider.provide() directly instead of going through ResourceCache.
3. Python side: Moved resource_cache.py from flink_agents/plan/ to
flink_agents/runtime/, updated all imports.
Note: ResourceProvider itself stays in plan since
AgentPlan.getResourceProviders() returns it — moving it would create a
plan→runtime circular dependency. Let me know if you intended something
different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
