Myracle commented on code in PR #27554:
URL: https://github.com/apache/flink/pull/27554#discussion_r3020204397
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -106,6 +106,31 @@ public class ExecutionConfigOptions {
+ "an additional stateful
operator.")
.build());
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<RowtimeNullHandling>
TABLE_EXEC_SOURCE_ROWTIME_NULL_HANDLING =
+ key("table.exec.source.rowtime-null-handling")
+ .enumType(RowtimeNullHandling.class)
+ .defaultValue(RowtimeNullHandling.FAIL)
+ .withDescription(
+ Description.builder()
+ .text(
+ "Specifies the behavior when the
rowtime field is null "
+ + "during watermark
generation.")
+ .linebreak()
+ .linebreak()
+ .text(
+ "FAIL: Throw a runtime exception
when encountering null rowtime (default). "
+ + "This preserves the
current behavior.")
Review Comment:
> It does not make much sense to say "This preserves the current behavior"
in the message - as " the current behaviour" could be read as something that is
occurring in the flow - but you mean the previous behaviour of the code.
>
> I suggest this option is the recommended option, as it is getting data
that is not meeting what we expect for rowTime, implying that the flow needs to
be cleaned up.
>
> I assume that this scenario occurs when a source gets null in a column
that should not be null or there is an error in the operator see
[here](https://stackoverflow.com/questions/65501591/how-to-resolve-error-rowtime-timestamp-is-null-in-flink-server).
>
> @alpinegizmo do you think this is a reasonable addition? If FAIL is not
specified ,we either lose data or pass on data that might cause issues
downstream.
@alpinegizmo Hi, can you help review the code? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
