Samrat002 opened a new pull request, #27906:
URL: https://github.com/apache/flink/pull/27906
## What is the purpose of the change
This pull request renames `NativeS3AccessHelper` to
`NativeS3ObjectOperations` in the Native S3 FileSystem module. The old name was
carried over from the legacy S3 connector pattern, where a generic "helper"
abstracted away differences between Hadoop and Presto implementations. Since
the Native S3 FileSystem has no such constraint, the class deserves a name that
reflects its actual responsibility: encapsulating low-level S3 object
operations (multipart upload lifecycle, putObject, getObject, deleteObject,
getObjectMetadata).
As noted in the
https://github.com/apache/flink/pull/27187/#discussion_r2821197577, a class
named ...Helper... signals "this class has no clear responsibility" — which is
inaccurate here.
Brief change log
- Renamed NativeS3AccessHelper to NativeS3ObjectOperations (file, class,
logger, constructors)
- Updated all references in NativeS3FileSystem, NativeS3RecoverableWriter,
NativeS3RecoverableFsDataOutputStream, NativeS3Committer
- Updated README.md class reference
## Verifying this change
Existing tests, such as NativeS3FileSystemFactoryTest and
S3ClientProviderTest, already cover this change. All existing tests pass
unchanged since the rename has no behavioural impact.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: yes (rename only, no behavioral change)
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
