spuru9 commented on code in PR #27910:
URL: https://github.com/apache/flink/pull/27910#discussion_r3072588601
##########
flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringSorting.java:
##########
@@ -363,9 +363,7 @@ private File generateFileWithStrings(int numStrings, String
prefix) throws IOExc
bld.append(prefix);
File f = File.createTempFile("strings", "txt");
- BufferedWriter wrt = null;
- try {
- wrt = new BufferedWriter(new FileWriter(f));
+ try (BufferedWriter wrt = new BufferedWriter(new FileWriter(f))) {
Review Comment:
It would be nice to have this change in
https://github.com/apache/flink/blob/106acbced18b0da5fa17181ef6a72738e5ab211c/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java#L392
and
https://github.com/apache/flink/blob/106acbced18b0da5fa17181ef6a72738e5ab211c/flink-tests/src/test/java/org/apache/flink/test/manual/MassiveStringValueSorting.java#L424
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
