Savonitar commented on code in PR #174: URL: https://github.com/apache/flink-connector-kafka/pull/174#discussion_r3079366223
########## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/config/FormatProjectionPushdownLevel.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.connectors.kafka.config; + +import org.apache.flink.annotation.Internal; + +/** + * Projection pushdown mode for {@link + * org.apache.flink.streaming.connectors.kafka.table.KafkaDynamicSource}. + */ +@Internal +public enum FormatProjectionPushdownLevel { Review Comment: I thought about this more and I agree with the three-level approach. Since the feature is disabled by default (`NONE`), the target audience is users who already understand projection pushdown and their format's capabilities. For those users, the distinction between `TOP_LEVEL` and `ALL` provides useful granularity, it allows them to enable top-level pushdown while opting out of nested projections, in case a format has bugs with nested projection despite declaring support via `supportsNestedProjection()`. Missing an optimization is better than wrong results (as the Avro bug demonstrates). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
