[ 
https://issues.apache.org/jira/browse/FLINK-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831895#comment-15831895
 ] 

ASF GitHub Bot commented on FLINK-5584:
---------------------------------------

Github user hongyuhong commented on the issue:

    https://github.com/apache/flink/pull/3175
  
    Hi, @wuchong, @sunjincheng121 ,
    Thank you very much for correcting my mistake!I will study deeply and 
modify the code. The pr temporarily only consider the processing-time and 
preceding section, and just do a translate between sql and logicalplan, cause 
currently  i can't find a windowoperator to describe the following section and 
event-time. I agree with that if row-window has been implement on tableapi, the 
streaming sql can support easily.
    Thank you again for your advice.


> Support Sliding-count row-window on streaming sql
> -------------------------------------------------
>
>                 Key: FLINK-5584
>                 URL: https://issues.apache.org/jira/browse/FLINK-5584
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Yuhong Hong
>
> Calcite has already support sliding-count row-window, the grammar look like:
> select sum(amount) over (rows 10 preceding) from Order;
> select sum(amount) over (partition by user rows 10 preceding) from Order;
> And it will parse the sql as a LogicalWindow relnode, the logical Window 
> contains aggregate func info and window info, it's similar to Flink 
> LogicalWIndowAggregate, so we can add an convert rule to directly convert 
> LogicalWindow into DataStreamAggregate relnode, and if Calcite support more 
> grammar, we can extend the convert rule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to