raminqaf commented on code in PR #27901:
URL: https://github.com/apache/flink/pull/27901#discussion_r3108691965
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/FromChangelogFunction.java:
##########
@@ -137,7 +138,10 @@ public void eval(
final StringData opCode = input.getString(opColumnIndex);
final RowKind rowKind = opMap.get(opCode);
if (rowKind == null) {
- return;
+ throw new ValidationException(
Review Comment:
I had it as `RuntimeException` at first but, It is explicitly mentioned in
the FLIP to throw an `ValidationException`
> 'FAIL' (default): Throws a ValidationException and fails the job. Ensures
strict validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
