davidradl commented on code in PR #31:
URL:
https://github.com/apache/flink-connector-http/pull/31#discussion_r3115958863
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpLookupConnectorOptions.java:
##########
@@ -131,6 +132,21 @@ public class HttpLookupConnectorOptions {
.noDefaultValue()
.withDescription("Http client connection timeout.");
+ /**
+ * HTTP request timeout for lookup source. Controls how long the HTTP
client waits for a
+ * response before timing out a single request. If not set, defaults to 30
seconds (matching the
+ * default behaviour of the connector).
+ */
+ public static final ConfigOption<Duration> SOURCE_LOOKUP_REQUEST_TIMEOUT =
Review Comment:
I see this is already present
[here](https://github.com/apache/flink-connector-http/blob/11400d2dfc526549e514450fadb69b2025e30aa0/flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/RequestFactoryBase.java#L82)
. It looks like this capability is already present at the the lower level; do
we need to augment the existing code at all. The additional doc seems clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
