davidradl commented on code in PR #33: URL: https://github.com/apache/flink-connector-http/pull/33#discussion_r3116105074
########## docs/content.zh/docs/connectors/table/http.md: ########## @@ -472,6 +405,7 @@ another format name. | http.sink.writer.thread-pool.size | optional | Sets the size of pool thread for HTTP Sink request processing. Increasing this value would mean that more concurrent requests can be processed in the same time. If not specified, the default value of 1 thread will be used. | | http.sink.writer.request.mode | optional | Sets the Http Sink request submission mode. Two modes are available: `single` and `batch`. Defaults to `batch` if not specified. | | http.sink.request.batch.size | optional | Applicable only for `http.sink.writer.request.mode = batch`. Sets number of individual events/requests that will be submitted as one HTTP request by HTTP sink. The default value is 500 which is same as HTTP Sink `maxBatchSize` | +| http.sink.retry.times | optional | Maximum number of retry attempts for HTTP Sink requests when a request fails due to a network error (IOException). Retries use exponential backoff with an initial delay of 1 second. Set to `0` to disable retries. Default value is `3`. | Review Comment: I see for lookup we have ``` http.source.lookup.retry-codes \| optional \| Comma separated http codes consid… -- \| http.source.lookup.retry-strategy.type \| optional \| Auto retry strategy type: fixed-d… \| http.source.lookup.retry-strategy.fixed-delay.delay \| optional \| Fixed-delay interval between retr… \| http.source.lookup.retry-strategy.exponential-delay.initial-backoff \| optional \| Exponential-delay initial delay. … \| http.source.lookup.retry-strategy.exponential-delay.max-backoff \| optional \| Exponential-delay maximum delay. … \| http.source.lookup.retry-strategy.exponential-delay.backoff-multiplier \| optional \| Exponential-delay multiplier. Def… ``` I was expecting the same for sink -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
