snuyanzin commented on code in PR #27994:
URL: https://github.com/apache/flink/pull/27994#discussion_r3122912643
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/FromChangelogInputTypeStrategyTest.java:
##########
@@ -148,6 +153,60 @@ protected Stream<TestSpec> testData() {
"c", "INSERT",
"u", "UPDATE_AFTER",
"d", "DELETE"))
- .expectErrorMessage("must include UPDATE_BEFORE"));
+ .expectErrorMessage("must include UPDATE_BEFORE"),
+
+ // Error: Invalid op handling mode
+ TestSpec.forStrategy(
+ "Invalid invalid_op_handling mode",
+ FROM_CHANGELOG_INPUT_TYPE_STRATEGY)
+ .calledWithArgumentTypes(TABLE_TYPE, DESCRIPTOR_TYPE,
MAP_TYPE, STRING_TYPE)
+ .calledWithTableSemanticsAt(0, new
TableSemanticsMock(TABLE_TYPE))
+ .calledWithLiteralAt(1, ColumnList.of(List.of("op")))
+ .calledWithLiteralAt(
+ 2,
+ Map.of(
+ "c", "INSERT",
+ "ub", "UPDATE_BEFORE",
+ "ua", "UPDATE_AFTER",
+ "d", "DELETE"))
+ .calledWithLiteralAt(3, "INVALID_MODE")
+ .expectErrorMessage(
+ "Invalid value for argument
'invalid_op_handling': 'INVALID_MODE'. Valid values are: FAIL, SKIP."),
+
+ // Error: invalid_op_handling is case-sensitive — lowercase is
rejected
+ TestSpec.forStrategy(
+ "Lowercase invalid_op_handling mode is
rejected",
+ FROM_CHANGELOG_INPUT_TYPE_STRATEGY)
+ .calledWithArgumentTypes(TABLE_TYPE, DESCRIPTOR_TYPE,
MAP_TYPE, STRING_TYPE)
+ .calledWithTableSemanticsAt(0, new
TableSemanticsMock(TABLE_TYPE))
+ .calledWithLiteralAt(1, ColumnList.of(List.of("op")))
Review Comment:
```suggestion
.calledWithLiteralAt(1, ColumnList.of("op"))
```
?
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/FromChangelogInputTypeStrategyTest.java:
##########
@@ -148,6 +153,60 @@ protected Stream<TestSpec> testData() {
"c", "INSERT",
"u", "UPDATE_AFTER",
"d", "DELETE"))
- .expectErrorMessage("must include UPDATE_BEFORE"));
+ .expectErrorMessage("must include UPDATE_BEFORE"),
+
+ // Error: Invalid op handling mode
+ TestSpec.forStrategy(
+ "Invalid invalid_op_handling mode",
+ FROM_CHANGELOG_INPUT_TYPE_STRATEGY)
+ .calledWithArgumentTypes(TABLE_TYPE, DESCRIPTOR_TYPE,
MAP_TYPE, STRING_TYPE)
+ .calledWithTableSemanticsAt(0, new
TableSemanticsMock(TABLE_TYPE))
+ .calledWithLiteralAt(1, ColumnList.of(List.of("op")))
+ .calledWithLiteralAt(
+ 2,
+ Map.of(
+ "c", "INSERT",
+ "ub", "UPDATE_BEFORE",
+ "ua", "UPDATE_AFTER",
+ "d", "DELETE"))
+ .calledWithLiteralAt(3, "INVALID_MODE")
+ .expectErrorMessage(
+ "Invalid value for argument
'invalid_op_handling': 'INVALID_MODE'. Valid values are: FAIL, SKIP."),
+
+ // Error: invalid_op_handling is case-sensitive — lowercase is
rejected
+ TestSpec.forStrategy(
+ "Lowercase invalid_op_handling mode is
rejected",
+ FROM_CHANGELOG_INPUT_TYPE_STRATEGY)
+ .calledWithArgumentTypes(TABLE_TYPE, DESCRIPTOR_TYPE,
MAP_TYPE, STRING_TYPE)
+ .calledWithTableSemanticsAt(0, new
TableSemanticsMock(TABLE_TYPE))
+ .calledWithLiteralAt(1, ColumnList.of(List.of("op")))
+ .calledWithLiteralAt(
+ 2,
+ Map.of(
+ "c", "INSERT",
+ "ub", "UPDATE_BEFORE",
+ "ua", "UPDATE_AFTER",
+ "d", "DELETE"))
+ .calledWithLiteralAt(3, "skip")
+ .expectErrorMessage(
+ "Invalid value for argument
'invalid_op_handling': 'skip'. Valid values are: FAIL, SKIP."),
+
+ // Error: invalid_op_handling is case-sensitive — mixed case
is rejected
+ TestSpec.forStrategy(
+ "Mixed-case invalid_op_handling mode is
rejected",
+ FROM_CHANGELOG_INPUT_TYPE_STRATEGY)
+ .calledWithArgumentTypes(TABLE_TYPE, DESCRIPTOR_TYPE,
MAP_TYPE, STRING_TYPE)
+ .calledWithTableSemanticsAt(0, new
TableSemanticsMock(TABLE_TYPE))
+ .calledWithLiteralAt(1, ColumnList.of(List.of("op")))
Review Comment:
```suggestion
.calledWithLiteralAt(1, ColumnList.of("op"))
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
