featzhang commented on PR #27562:
URL: https://github.com/apache/flink/pull/27562#issuecomment-4318570285
Force-pushed to resolve merge conflicts with master after #27567 (Triton
health check & circuit breaker) was merged.
**What changed in this push:**
1. **Rebased on the latest master** — the previous branch base was several
months behind, so I re-applied the sequence-id changes cleanly on top of
current `master` to avoid a noisy reverse diff.
2. **Integrated with #27567's lifecycle** — `sequenceCounter` and
`subtaskIndex` are now declared as `protected transient` fields on
`AbstractTritonModelFunction` and initialized inside the existing
`open(FunctionContext)` method, consistent with how `healthChecker` and
`circuitBreaker` are wired up.
3. **Fixed subtask index lookup** — previously used
`context.getJobParameter("flink.subtask.index", "0").hashCode()`, which is not
a real Flink job parameter key. Replaced with the proper API:
`context.getTaskInfo().getIndexOfThisSubtask()`.
4. **Added config validation** — the constructor now fails fast if
`sequence-id-auto-increment` is enabled without `sequence-id` being configured.
5. **Dropped an unrelated `.gitignore` change** that had slipped into the
previous commit.
6. **Squashed the follow-up Spotless commit** into a single commit for a
clean history.
**Verification locally:**
- `mvn -pl flink-models/flink-model-triton compile` → BUILD SUCCESS
- `mvn -pl flink-models/flink-model-triton spotless:check checkstyle:check`
→ PASS
- `mvn -pl flink-models/flink-model-triton test` → 63/63 tests pass
(including the existing `TritonHealthCheckerTest` / `TritonCircuitBreakerTest`
that exercise `open()`)
Final diff: 3 files changed, +78/-2. Ready for another CI run. Thanks for
the patience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
