featzhang commented on PR #27561: URL: https://github.com/apache/flink/pull/27561#issuecomment-4319901446
## CI Failure Analysis The CI failure (build [#74498](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=74498)) is a **flaky infrastructure issue unrelated to this PR's code**. **Root cause:** Maven failed to download `bcprov-jdk18on:1.80.jar` from Google Maven Central due to a premature connection termination: ``` Could not transfer artifact org.bouncycastle:bcprov-jdk18on:jar:1.80 from/to google-maven-central: Premature end of Content-Length delimited message body (expected: 8,682,747; received: 5,767,168) ``` This is a transient network error on the CI side. @flinkbot run azure --- ## Code Review Note The code overall looks well-designed. One minor documentation inconsistency worth addressing: In `TritonOptions.MAX_RETRIES` the description states: > *"Only transient failures are retried: network errors, 5xx responses, and **response parsing failures**."* However, in `TritonInferenceModelFunction.java`, `JsonProcessingException` (response parsing failure) is routed with `retryable=false`: ```java handleFailureWithRetry(rowData, future, attemptNumber, parseException, /* countAsBreakerFailure */ false, /* retryable */ false); // <-- not retried ``` The code comment explains the rationale correctly: a JSON parse failure is a deterministic bug (either in response handling or the server's response schema) where retrying cannot help. The implementation decision is sound — the documentation just needs to be updated to match. **Suggestion:** Update the `MAX_RETRIES` Javadoc to remove "response parsing failures" from the list of retryable conditions, or add a note clarifying that deterministic parsing failures are excluded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
