och5351 commented on code in PR #171: URL: https://github.com/apache/flink-connector-jdbc/pull/171#discussion_r3143422269
########## flink-connector-jdbc-clickhouse/src/main/java/org/apache/flink/connector/jdbc/clickhouse/database/ClickHouseFactory.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.clickhouse.database; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.jdbc.clickhouse.database.dialect.ClickHouseDialect; +import org.apache.flink.connector.jdbc.core.database.JdbcFactory; +import org.apache.flink.connector.jdbc.core.database.catalog.JdbcCatalog; +import org.apache.flink.connector.jdbc.core.database.dialect.JdbcDialect; + +/** Factory for {@link ClickHouseDialect}. */ +@Internal +public class ClickHouseFactory implements JdbcFactory { + @Override + public boolean acceptsURL(String url) { + return url.startsWith("jdbc:clickhouse:"); Review Comment: Should we support the jdbc:ch: alias as well? ```suggestion return url.startsWith("jdbc:clickhouse:") || url.startsWith("jdbc:ch:"); ``` ########## flink-connector-jdbc-clickhouse/src/main/java/org/apache/flink/connector/jdbc/clickhouse/database/lineage/ClickHouseJdbcExtractor.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.clickhouse.database.lineage; + +import io.openlineage.client.utils.jdbc.JdbcExtractor; +import io.openlineage.client.utils.jdbc.JdbcLocation; +import io.openlineage.client.utils.jdbc.OverridingJdbcExtractor; + +import java.net.URISyntaxException; +import java.util.Properties; + +/** Implementation of {@link JdbcExtractor} for ClickHouse. */ +public class ClickHouseJdbcExtractor implements JdbcExtractor { + public ClickHouseJdbcExtractor() {} + + private JdbcExtractor delegate() { + return new OverridingJdbcExtractor("clickhouse", "8443"); + } + + public boolean isDefinedAt(String jdbcUri) { + return this.delegate().isDefinedAt(jdbcUri); + } + + public JdbcLocation extract(String rawUri, Properties properties) throws URISyntaxException { + return this.delegate().extract(rawUri, properties); + } +} Review Comment: This is non-blocking issue. The default port could be 8123 per the https://clickhouse.com/docs/integrations/language-clients/java/jdbc#configuration. Also, would you consider supporting the jdbc:ch: alias by normalizing it to clickhouse:? ```suggestion /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package org.apache.flink.connector.jdbc.clickhouse.database.lineage; import io.openlineage.client.utils.jdbc.JdbcExtractor; import io.openlineage.client.utils.jdbc.JdbcLocation; import io.openlineage.client.utils.jdbc.OverridingJdbcExtractor; import java.net.URISyntaxException; import java.util.Properties; /** Implementation of {@link JdbcExtractor} for ClickHouse. */ public class ClickHouseJdbcExtractor implements JdbcExtractor { public ClickHouseJdbcExtractor() {} private JdbcExtractor delegate() { return new OverridingJdbcExtractor("clickhouse", "8123"); } @Override public boolean isDefinedAt(String jdbcUri) { return jdbcUri.startsWith("ch:") || jdbcUri.startsWith("clickhouse:"); } @Override public JdbcLocation extract(String rawUri, Properties properties) throws URISyntaxException { // Normalize scheme and remove protocol prefix (similar to how PostgreSQL removes SSL info) String normalizedUri = rawUri .replaceFirst("^ch:", "clickhouse:") .replaceFirst("^clickhouse:(https?|grpc)://", "clickhouse://"); return delegate().extract(normalizedUri, properties); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
