featzhang commented on PR #27614: URL: https://github.com/apache/flink/pull/27614#issuecomment-4324349274
@flinkbot run azure Addressed the large-scale planner test failures from the previous CI round. Root cause: the original change added rowcount/cumulative cost output at SqlExplainLevel.EXPPLAN_ATTRIBUTES, which is reused by Stream/BatchPlanner for internal AST/plan serialization. That accidentally rewrote the baseline plan string used by thousands of rule/SQL tests. Redesign in this revision: - Introduced a dedicated `withRowCountAndCost` flag on `RelTreeWriterImpl` / `FlinkRelOptUtil.toString`. It only controls rendering; it does not overload the semantics of `SqlExplainLevel`. - Stream/BatchPlanner turn the flag on only for the '== Optimized Physical Plan ==' section of user-visible EXPLAIN output. The '== Abstract Syntax Tree ==' section and every internal AST-serialization callsite keep the flag off, so no existing rule / plan baselines are affected. - ExplainTest.xml and /explain/*.out fixtures are updated with rowcount/cost placeholders for the default-level explain, aligning with how `ExplainDetail.ESTIMATED_COST` baselines already work. Unstable numeric costs are normalized via the existing `replaceEstimatedCost` helper, which is now applied unconditionally. Verified locally: ExplainTest (40/40), TableEnvironmentTest (121/121), and a suite of 29 Rule/SQL tests (403/403) previously red are all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
