gyfora commented on code in PR #1104:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1104#discussion_r3152318259
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -240,6 +247,11 @@ private Optional<String> validateJobSpec(
Configuration configuration = Configuration.fromMap(confMap);
+ Optional<String> jarUriError = validateJarURI(job.getJarURI(),
configuration);
Review Comment:
I don't really think that we should validate Application jarURIs here. I
think session job validation makes sense because of the http download and local
access on the operator pod but for applications these don't really matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
