mateczagany commented on code in PR #28041: URL: https://github.com/apache/flink/pull/28041#discussion_r3153663744
########## flink-python/src/main/resources/META-INF/NOTICE: ########## @@ -57,18 +58,8 @@ The bundled Apache Beam dependencies bundle the following dependencies under the - io.grpc:grpc-protobuf:1.59.1 - io.grpc:grpc-stub:1.59.1 - io.grpc:grpc-testing:1.59.1 -- io.netty:netty-buffer:4.1.100.Final -- io.netty:netty-codec:4.1.100.Final -- io.netty:netty-codec-http:4.1.100.Final -- io.netty:netty-codec-http2:4.1.100.Final -- io.netty:netty-codec-socks:4.1.100.Final -- io.netty:netty-common:4.1.100.Final -- io.netty:netty-handler:4.1.100.Final -- io.netty:netty-handler-proxy:4.1.100.Final -- io.netty:netty-resolver:4.1.100.Final -- io.netty:netty-transport:4.1.100.Final -- io.netty:netty-transport-native-epoll:4.1.100.Final:linux-x86_64 -- io.netty:netty-transport-native-unix-common:4.1.100.Final +- io.netty:netty-buffer:4.2.6.Final +- io.netty:netty-common:4.2.6.Final Review Comment: I agree that Netty should be upgraded to the latest version, it would also greatly simplify the current license overrides in flink-shaded. I would personally wait for a new flink-shaded version to be released with a new Netty version, then also upgrade `netty-bom` in the Flink main pom.xml, that way flink-python will get the new version too. I'll create a PR to upgrade Netty in flink-shaded in the next few days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
