snuyanzin commented on code in PR #28053:
URL: https://github.com/apache/flink/pull/28053#discussion_r3156821185
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/common/UnnestTestBase.scala:
##########
@@ -282,6 +282,20 @@ abstract class UnnestTestBase(withExecPlan: Boolean)
extends TableTestBase {
"SELECT bd_name FROM nested_not_null LEFT JOIN
UNNEST(nested_not_null.nested_array[0].data) AS exploded_bd(bd_name) ON TRUE")
}
+ @Test
+ def testNullMismatchLeftJoinNoAliasList(): Unit = {
+ // Bare Uncollect under the LEFT correlate (no column-list alias inserts
no Project).
+ util.verifyRelPlan(
+ "SELECT * FROM nested_not_null LEFT JOIN
UNNEST(nested_not_null.business_data) AS exploded_bd ON TRUE")
+ }
+
+ @Test
+ def testNullMismatchLeftJoinOnPredicate(): Unit = {
+ // ON-clause predicate adds a LogicalFilter between the LEFT correlate and
the Uncollect.
+ util.verifyRelPlan(
+ "SELECT * FROM nested_not_null LEFT JOIN
UNNEST(nested_not_null.business_data) AS exploded_bd ON exploded_bd <> 'debug'")
+ }
Review Comment:
why do we need comments here?
is sql not self explainable?
If you do something which is different from others (other tests in this
file) you need justification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
