twalthr commented on code in PR #28061:
URL: https://github.com/apache/flink/pull/28061#discussion_r3159395933
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionTestUtils.java:
##########
@@ -940,6 +940,18 @@ public ChangelogMode getChangelogMode(ChangelogContext
changelogContext) {
}
}
+ /**
+ * Testing function that is itself non-deterministic (isDeterministic() =
false). Used to verify
+ * that Concern 1 (PTF own non-determinism) is caught by the NDU visitor
when downstream
+ * requires deterministic output columns.
+ */
+ public static class NonDeterministicUpdatingRetractFunction extends
UpdatingRetractFunction {
Review Comment:
Remove all the disabling of the NDU analyzer in semantic and other PTFs
tests. If I remember correctly, there are a couple of TODOs in various PTF
tests for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
