RocMarshal commented on code in PR #28040:
URL: https://github.com/apache/flink/pull/28040#discussion_r3162290042
##########
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/DownloadCache.java:
##########
@@ -30,7 +29,15 @@
*
* <p>Whether, how, and for how long files are cached is
implementation-dependent.
*/
-public interface DownloadCache extends ExternalResource {
+public interface DownloadCache {
+
+ void before() throws Exception;
+
+ void afterTestSuccess();
+
+ default void afterTestFailure() {
+ afterTestSuccess();
+ }
Review Comment:
Could you help add some comment lines to describe the methods definetion ?
##########
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkResource.java:
##########
@@ -30,7 +29,15 @@
import java.util.stream.Stream;
/** Generic interface for interacting with Flink. */
-public interface FlinkResource extends ExternalResource {
+public interface FlinkResource {
+
+ void before() throws Exception;
+
+ void afterTestSuccess();
+
+ default void afterTestFailure() {
+ afterTestSuccess();
+ }
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
