lvyanquan commented on code in PR #4308:
URL: https://github.com/apache/flink-cdc/pull/4308#discussion_r3165889421
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksEnrichedCatalog.java:
##########
@@ -38,6 +41,70 @@ public StarRocksEnrichedCatalog(String jdbcUrl, String
username, String password
private static final Logger LOG =
LoggerFactory.getLogger(StarRocksEnrichedCatalog.class);
+ @Override
+ public void createTable(StarRocksTable table, boolean ignoreIfExists)
+ throws StarRocksCatalogException {
+ String createTableSql = buildCreateTableSql(table, ignoreIfExists);
+ try {
+ executeUpdateStatement(createTableSql);
+ LOG.info(
+ "Success to create table {}.{}, sql: {}",
+ table.getDatabaseName(),
+ table.getDatabaseName(),
Review Comment:
table.getDatabaseName() => table.getTableName()
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierITCase.java:
##########
@@ -101,7 +101,9 @@ private List<Event> generateAddColumnEvents(TableId
tableId) {
Schema.newBuilder()
.column(new PhysicalColumn("id",
DataTypes.INT().notNull(), null))
.column(new PhysicalColumn("number",
DataTypes.DOUBLE(), null))
- .column(new PhysicalColumn("name",
DataTypes.VARCHAR(17), null))
+ .column(
+ new PhysicalColumn(
+ "name", DataTypes.VARCHAR(17),
"\"name\"", "\"\""))
Review Comment:
Can you add test cases for default values/comments containing '\\'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
