Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178529871
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/reader/RedisStreamsSourceReader.java: ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.reader; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.SourceReaderContext; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.base.source.reader.SingleThreadMultiplexSourceReaderBase; +import org.apache.flink.connector.base.source.reader.fetcher.SingleThreadFetcherManager; +import org.apache.flink.connector.redis.streams.source.RedisStreamsDeserializationSchema; +import org.apache.flink.connector.redis.streams.source.reader.split.RedisStreamsSplitReader; +import org.apache.flink.connector.redis.streams.source.split.RedisStreamsSourceSplit; +import org.apache.flink.connector.redis.streams.source.split.RedisStreamsSourceSplitState; +import org.apache.flink.util.Preconditions; + +import io.lettuce.core.StreamMessage; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.List; +import java.util.Map; +import java.util.concurrent.atomic.AtomicReference; + +/** Source reader for Redis Streams. */ +@Internal +public class RedisStreamsSourceReader<T> + extends SingleThreadMultiplexSourceReaderBase< + StreamMessage<String, String>, + T, + RedisStreamsSourceSplit, + RedisStreamsSourceSplitState> { + + private static final Logger LOG = LoggerFactory.getLogger(RedisStreamsSourceReader.class); + + private final AtomicReference<RedisStreamsSplitReader> splitReaderRef; Review Comment: You're right that the Kafka connector uses a typed FetcherManager subclass (e.g., KafkaSourceFetcherManager) to expose custom operations like commitOffsets(), and that's the cleaner pattern. The AtomicReference does feel like a workaround. The reason it works correctly here is `SingleThreadFetcherManager` creates the SplitReader lazily on the first `addSplits()` call but snapshotState() and `notifyCheckpointComplete()` are always called after at least one split has been assigned, so splitReaderRef.get() is non-null by the time any ACK operation fires. The null-guard on every call makes the gap explicit. Refactoring to a RedisFetcherManager subclass is the right end state. I'll do that as a follow-up once the core is stable, to avoid mixing a structural change into the initial PR. please let me know if you think this is blocker for core implementation Reference ticket for this followup https://issues.apache.org/jira/browse/FLINK-39593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
