Efrat19 commented on code in PR #174:
URL:
https://github.com/apache/flink-connector-kafka/pull/174#discussion_r3186314271
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/DynamicKafkaDeserializationSchema.java:
##########
@@ -139,7 +142,7 @@ public void deserialize(ConsumerRecord<byte[], byte[]>
record, Collector<RowData
throws IOException {
// shortcut in case no output projection is required,
// also not for a cartesian product with the keys
- if (keyDeserialization == null && !hasMetadata) {
+ if (keyDeserialization == null && !hasMetadata && !hasValueProjection)
{
Review Comment:
value projection might be needed even if
`valueFormatProjectionPushdownLevel` is set to `NONE` (i.e columns reordering)
am I right?
So by default we are presenting another limitation on the shortcut path
Is there any way to avoid it given `deserialize` is the record level hotpath?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
