raminqaf opened a new pull request, #28116:
URL: https://github.com/apache/flink/pull/28116
## What is the purpose of the change
This PR adds an overload of
`ShowCreateUtil.buildShowCreateMaterializedTableRow` that accepts two flags,
`includeFreshness` and `includeRefreshMode`, controlling whether the
`FRESHNESS` and `REFRESH_MODE` clauses appear in the rendered `SHOW CREATE
MATERIALIZED TABLE` output.
The existing 6-arg overload delegates to the new 8-arg overload with `true,
true`, so all current callers are unaffected. Deployments that fix freshness or
refresh mode at the platform level can now suppress these clauses from `SHOW
CREATE` output without post-processing the result with regexes.
## Brief change log
- Added 8-arg overload `buildShowCreateMaterializedTableRow(table,
identifier, isTemporary, createOrAlter, timeZoneId, sqlFactory,
includeFreshness, includeRefreshMode)` in `ShowCreateUtil`.
- Existing 6-arg public overload now delegates to the new one with
`includeFreshness=true, includeRefreshMode=true`.
- The 8-arg path conditionally emits the `FRESHNESS` and `REFRESH_MODE`
lines based on the flags.
## Verifying this change
This change is already covered by existing tests, such as the cases in
`ShowCreateUtilTest` that exercise materialized table rendering. Those tests go
through the 6-arg overload, which now routes to the new 8-arg overload with
`true, true`, so they assert the unchanged output.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no (`ShowCreateUtil` is `@Internal`)
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
