davidradl commented on code in PR #245:
URL:
https://github.com/apache/flink-connector-aws/pull/245#discussion_r3187738823
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/FanOutKinesisShardSubscription.java:
##########
@@ -108,7 +107,8 @@ public void activateSubscription() {
shardId,
startingPosition,
consumerArn);
- if (subscriptionActive.get()) {
+ if (shardSubscriber != null
+ && shardSubscriber.getSubscriptionState() ==
SubscriptionState.SUBSCRIBED) {
Review Comment:
nit: should we change the message. It refers to the subscription being
active , which seems to be tied to the subscriptionActive variable we have
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
