swapna267 commented on code in PR #28115: URL: https://github.com/apache/flink/pull/28115#discussion_r3191777787
########## flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroVariantDeserializationSchemaTest.java: ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.avro; Review Comment: I see we would need to, 1. Have a custom connector that can pass records of varying schemas (as we don't have the Kafka local connector). I see something similar to `TestProtobufTableFactory` 2. MockSchemaRegistry Http Server 3. Include Flink Table / Streaming API dependencies into flink-formats module Let me know if you have any other ideas here or any such existing integration tests. As we already have test cases covering those code paths through individual tests, Do you think we need this integration test here ? If the idea is, if this test case can act more like a documentation or reference for this use case, would adding that details to the documentation for this format in specific will help ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
