xintongsong commented on code in PR #631:
URL: https://github.com/apache/flink-agents/pull/631#discussion_r3195720216
##########
api/src/main/java/org/apache/flink/agents/api/event/ChatRequestEvent.java:
##########
@@ -18,40 +18,75 @@
package org.apache.flink.agents.api.event;
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.flink.agents.api.Event;
import org.apache.flink.agents.api.chat.messages.ChatMessage;
import javax.annotation.Nullable;
+import java.util.ArrayList;
import java.util.List;
+import java.util.Map;
/** Event representing a request for chat. */
public class ChatRequestEvent extends Event {
- private final String model;
- private final List<ChatMessage> messages;
- private final @Nullable Object outputSchema;
+
+ public static final String EVENT_TYPE = "_chat_request_event";
+
+ private static final ObjectMapper MAPPER = new ObjectMapper();
public ChatRequestEvent(
String model, List<ChatMessage> messages, @Nullable Object
outputSchema) {
- this.model = model;
- this.messages = messages;
- this.outputSchema = outputSchema;
+ super(EVENT_TYPE);
+ setAttr("model", model);
+ setAttr("messages", messages);
+ if (outputSchema != null) {
+ setAttr("output_schema", outputSchema);
+ }
}
public ChatRequestEvent(String model, List<ChatMessage> messages) {
this(model, messages, null);
}
+ /**
+ * Reconstructs a typed ChatRequestEvent from a base Event, deserializing
nested types.
+ *
+ * @param event the base event containing chat request data in attributes
+ * @return a typed ChatRequestEvent
+ */
+ @SuppressWarnings("unchecked")
+ public static ChatRequestEvent fromEvent(Event event) {
+ String model = (String) event.getAttr("model");
+ List<?> rawMessages = (List<?>) event.getAttr("messages");
+ List<ChatMessage> messages = new ArrayList<>();
+ if (rawMessages != null) {
+ for (Object m : rawMessages) {
+ if (m instanceof ChatMessage) {
+ messages.add((ChatMessage) m);
+ } else if (m instanceof Map) {
+ messages.add(MAPPER.convertValue(m, ChatMessage.class));
+ }
+ }
+ }
+ return new ChatRequestEvent(model, messages,
event.getAttr("output_schema"));
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
