davidradl commented on code in PR #28074:
URL: https://github.com/apache/flink/pull/28074#discussion_r3196254891
##########
flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/RowDataSerializer.java:
##########
@@ -225,5 +226,32 @@ public TypeSerializerSchemaCompatibility<RowData>
resolveSchemaCompatibility(
return intermediateResult.getFinalResult();
}
+
+ /**
+ * Returns true when new field types are structurally equal to old
ones ignoring top-level
Review Comment:
I am curious why this is only top level. Is this top level piece a Flink
planner restriction? I would expect a nullable nested row should be compatible
- even it is contained non-nullable fields. i.e. if I have a company object
with a nullable customers array, Each customer could have a mandatory name;
whcih would mean when there is a customer instance is needs a name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
