raminqaf commented on PR #28025: URL: https://github.com/apache/flink/pull/28025#issuecomment-4389742485
> Thanks for the quick updates, @raminqaf! Code is looking good. Could you align this with #28120 where I moved our shared utility to [ChangelogTypeStrategyUtils.java](https://github.com/apache/flink/pull/28120/changes#diff-a4a5e455f6773ded0ba51b6a38abe1f6dfd857297c324fd75445bfee2b85fade)flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ChangelogTypeStrategyUtils.java Thanks @gustavodemorais for the feedbacks. I have aligned the latest changes. If the code looks good enough we can processed with the merge and continue the work on the Utils on your PR or a followup PR so the changes are not blocked here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
