1fanwang commented on code in PR #28047:
URL: https://github.com/apache/flink/pull/28047#discussion_r3198511783
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/ServiceType.java:
##########
@@ -64,7 +63,7 @@ public Service buildUpExternalRestService(
.getType())
.withSelector(kubernetesJobManagerParameters.getSelectors())
.addNewPort()
- .withName(Constants.REST_PORT_NAME)
+
.withName(kubernetesJobManagerParameters.getRestServicePortName())
Review Comment:
Done — `InitJobManagerDecorator#getContainerPorts` now reads the same
configured name. I broadened the option's description to reflect that it covers
both the Service port and the container port. New test
`testMainContainerRestPortNameWithCustomConfig` covers it. 0cf59c1acd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
