snuyanzin commented on code in PR #28113:
URL: https://github.com/apache/flink/pull/28113#discussion_r3201698256
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala:
##########
@@ -116,6 +115,41 @@ class CodeGeneratorContext(
val reusableInputUnboxingExprs: mutable.Map[(String, Int),
GeneratedExpression] =
mutable.Map[(String, Int), GeneratedExpression]()
+ // map of expressions for shared RexProgram exprList entries that will be
added only once
+ // exprList index -> expr
+ val reusableLocalRefExprs: mutable.LinkedHashMap[Int, GeneratedExpression] =
Review Comment:
yes, however it is in fact localref expr from bottom scope
so renamed it and changed to `def` instead of `val`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
