Savonitar commented on code in PR #241:
URL:
https://github.com/apache/flink-connector-kafka/pull/241#discussion_r3204340482
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaRecordEmitter.java:
##########
@@ -53,7 +53,13 @@ public void emitRecord(
deserializationSchema.deserialize(consumerRecord,
sourceOutputWrapper);
splitState.setCurrentOffset(consumerRecord.offset() + 1);
} catch (Exception e) {
- throw new IOException("Failed to deserialize consumer record due
to", e);
+ throw new IOException(
+ String.format(
+ "Failed to deserialize consumer record from
topic=%s, partition=%d, offset=%d due to",
Review Comment:
Just an observation, that pre-existing to this PR trailing "due to" becomes
"due to at" which is bit oddly.
e.g.
```
java.io.IOException: Failed to deserialize consumer record from
topic=test-topic, partition=17, offset=216250171 due to
at
org.apache.flink.connector.kafka.source.reader.KafkaRecordEmitter.emitRecord(KafkaRecordEmitter.java:59)
```
Not a problem, indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
