Samrat002 opened a new pull request, #28132: URL: https://github.com/apache/flink/pull/28132
## What is the purpose of the change
`Preconditions.checkArgument` in Flink uses a simplified formatter that
only supports `%s` placeholders (not `%d`, `%f`, etc.). Three validation error
messages in
`NativeS3FileSystemFactory` used `%d` for numeric values, causing the
format specifier to appear literally in the output while the actual value was
appended in brackets —
e.g.:
s3.upload.min.part.size must be at least 5MB (5242880 bytes), but was %d
bytes [1048576]
s3.upload.max.concurrent.uploads must be positive, but was %d [0]
This fix replaces `%d` with `%s` so values are substituted correctly.
## Brief change log
- Replace `%d` with `%s` in three `Preconditions.checkArgument` format
strings in `NativeS3FileSystemFactory` (part size min, part size max, max
concurrent uploads)
## Verifying this change
This change is already covered by existing tests:
- `NativeS3FileSystemFactoryTest#testPartSizeTooSmallThrowsException`
- `NativeS3FileSystemFactoryTest#testPartSizeTooLargeThrowsException`
-
`NativeS3FileSystemFactoryTest#testInvalidMaxConcurrentUploadsThrowsException`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: yes
## Documentation
- Does this pull request introduce a new feature? no
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
