Samrat002 commented on code in PR #27788:
URL: https://github.com/apache/flink/pull/27788#discussion_r3214472032
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -255,14 +270,14 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
+ "When not set, the default chain is
used: delegation tokens -> "
+ "static credentials (if configured) ->
DefaultCredentialsProvider.");
- private Configuration flinkConfig;
+ private volatile Configuration flinkConfig;
+ @Nullable private volatile BucketConfigProvider bucketConfigProvider;
@Override
public String getScheme() {
return "s3";
}
- // setting to least priority so that it is not used by default
Review Comment:
Removed — making the fields `volatile` was unrelated to this feature. The
fields are now non-volatile as they were in master; `configure()` is called
once before `create()` so no visibility guarantee beyond happens-before is
needed.
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -264,7 +269,8 @@ public class NativeS3FileSystemFactory implements
FileSystemFactory {
+ "When not set, the default chain is
used: delegation tokens -> "
+ "static credentials (if configured) ->
DefaultCredentialsProvider.");
- private Configuration flinkConfig;
+ @Nullable private volatile Configuration flinkConfig;
+ @Nullable private volatile BucketConfigProvider bucketConfigProvider;
Review Comment:
There was no real purpose — it was a mistaken addition. The fields have been
restored to plain (non-volatile) `@Nullable` fields, matching master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
