Savonitar commented on code in PR #1111: URL: https://github.com/apache/flink-kubernetes-operator/pull/1111#discussion_r3220506947
########## examples/flink-python-example/README.md: ########## @@ -63,7 +63,10 @@ Dockerfile **Step 2**: Build docker image -Check this [doc](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/standalone/docker/#using-flink-python-on-docker) for more details about building Pyflink image. Note, Pyflink 1.15.3 is only supported on x86 arch. +Check this [doc](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/standalone/docker/#using-flink-python-on-docker) for more details about building a PyFlink image. The included Dockerfile is based on `flink:2.2` and installs PyFlink 2.2.0 (which supports Python 3.9, 3.10, 3.11 and 3.12). + +Note: PyFlink's `pemja` dependency only ships pre-built Linux wheels for `x86_64`. On other architectures (e.g. Apple Silicon) the build falls back to compiling from source, which fails because `flink:2.2` ships a JRE-only image. Build for `linux/amd64` explicitly in that case (`docker build --platform linux/amd64 ...`). Review Comment: Thanks for catching this. However, I took a slightly different approach: instead of the comment/uncomment toggle, I made `--platform linux/amd64` the default in the example: 1. It's a no-op on x86 2. on Apple Silicon Docker Desktop emulates amd64 transparently (verified end-to-end on minikube). The result is a single command that can be copy-pasted and that works on both archs. Updated the description. I'm happy to switch to your toggle suggestion if you'd prefer it. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
