snuyanzin commented on code in PR #39:
URL: 
https://github.com/apache/flink-connector-hive/pull/39#discussion_r3221554987


##########
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/FlinkEmbeddedHiveRunnerExtension.java:
##########
@@ -246,7 +197,8 @@ public boolean isAutoStart() {
         }
     }
 
-    private void loadAnnotatedSetupScripts(Class testClass, HiveShellBuilder 
hiveShellBuilder) {
+    private void loadAnnotatedSetupScripts(
+            final Class<?> testClass, HiveShellBuilder hiveShellBuilder) {

Review Comment:
   can we align on style: either all args are final or none of them, however 
not mixed
   here and in other places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to