jlalwani-amazon opened a new pull request, #42:
URL: https://github.com/apache/flink-connector-hive/pull/42

   ## What is the purpose of the change
   
   Remove the legacy `HiveCatalog.getTableFactory()` override and its 
associated test. This method returns the old `TableFactory` interface (now in 
`org.apache.flink.table.legacy.factories`) which has been fully replaced by 
`HiveDynamicTableFactory` discovered via SPI through `getFactory()`.
   
   *JIRA: [FLINK-39656](https://issues.apache.org/jira/browse/FLINK-39656)*
   
   ## Brief change log
   
   - Remove `getTableFactory()` override from `HiveCatalog`
   - Remove `testGenericTable` from `HiveTableFactoryTest` (tested the legacy 
path)
   - Remove unused legacy imports
   
   ## Verifying this change
   
   CI passed on fork: 
https://github.com/jlalwani-amazon/flink-connector-hive/actions
   
   ```bash
   mvn compile test-compile -pl flink-connector-hive -am
   ```
   
   ## Does this pull request potentially affect one of the following parts?
   
   - Dependencies: **no**
   - The public API: **no** (removes deprecated/legacy code path)
   - The serializers: **no**
   - The runtime per-record code paths: **no**
   - Anything that affects deployment or recovery: **no**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to