wenjin272 commented on code in PR #638:
URL: https://github.com/apache/flink-agents/pull/638#discussion_r3231206115
##########
api/src/main/java/org/apache/flink/agents/api/logger/EventLoggerConfig.java:
##########
@@ -33,20 +33,31 @@
* <h3>Usage Examples</h3>
*
* <pre>{@code
- * // Enable default file-based event logging with custom properties
+ * // Enable file-based event logging with custom properties
* EventLoggerConfig fileConfig = EventLoggerConfig.builder()
- * .loggerType("file")
+ * .loggerType(LoggerType.FILE)
* .property("baseLogDir", "/tmp/logs")
Review Comment:
Currently, the property needs to be placed under the key
AGENT_CONFIG_PROPERTY_KEY, but the JavaDoc here is inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
