snuyanzin commented on code in PR #28152:
URL: https://github.com/apache/flink/pull/28152#discussion_r3234996870


##########
flink-table/flink-sql-parser/src/main/codegen/templates/Parser.jj:
##########
@@ -4796,8 +4841,14 @@ SqlLiteral DateTimeLiteral() :
         return SqlLiteral.createUnknown("TIMESTAMP", p, s.end(this));
     }
 |
-    <TIMESTAMP> { s = span(); } <WITH> <LOCAL> <TIME> <ZONE> p = 
SimpleStringLiteral() {
-        return SqlLiteral.createUnknown("TIMESTAMP WITH LOCAL TIME ZONE", p, 
s.end(this));
+    LOOKAHEAD(2)
+        <TIME> { s = span(); } <WITH> ( <LOCAL> { local = true; } )? <TIME> 
<ZONE> p = SimpleStringLiteral() {
+            return SqlLiteral.createUnknown("TIME WITH " + (local ? "LOCAL " : 
"") + "TIME ZONE", p, s.end(this));
+        }
+|
+    LOOKAHEAD(2)
+    <TIMESTAMP> { s = span(); } <WITH> ( <LOCAL> { local = true; } )? <TIME> 
<ZONE> p = SimpleStringLiteral() {
+        return SqlLiteral.createUnknown("TIMESTAMP WITH " + (local ? "LOCAL " 
: "") + "TIME ZONE", p, s.end(this));

Review Comment:
   So far not supported in Flink's typeFactory, will fail there in case of 
attempt to use
   could be implemented separately



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to